On Set Bonus

[Dingle]

A thread recently got Necro'd which had a discussion going about this, so I thought I'd confirm some things:

1) Godly and below never mix with Mythical and above
2) Mythical and above mix fine
3) Set bonuses are: 25%(Godly -), 30% (Myth, non-Myth Zam), 33% (Trans), 36% (Supreme). Not sure if Zam gets better Myth/Trans/Supreme multipliers, but it's possible.
4) Each armor piece gets the set bonus appropriate to that - having 2 pieces trans and 2 pieces myth would get 33% on the Trans and 30% on the Myths

The code which prevents Mythical from getting a set bonus with non-Mythical is this:

if(isMythical && EquipmentOfType.NameIndex_QualityDescriptor < 13) //mythical armors can only full-set with other mythical armors
{
return false;
}

Note two things: The code only checks if the item is below mythical quality before not giving set bonus, and the comment states that "mythical armors can only full-set with other mythical armors"

That latter part isn't true, but it does mean that this section of code hasn't been updated for Trans/Supreme armor. Just remember that comments aren't code, so it doesn't matter if they're not updated (though to prevent confusing modders, Trendy should consider revisiting set bonuses and deciding whether to make the comment correct, or to correct the comment...)

[Commish]

Some raw data on Zamira:
195 - 260 w/ bonus (1.33333)
105 - 140 (1.33333)
150 - 200 (1.33333)
188 - 251 (1.335x -- rounded up 33.333 bonus)
145 - 193 (1.331x -- rounded down with 33.333 bonus)

Pretty sure Zamira is 1/3 bonus (33-1/3%) with rounding to the nearest integer

[Rageamok]

My proof from the other thread

Mixing
Not mixing

!!

[Dingle]

My proof from the other thread

Mixing
Not mixing

!!

As far as I can tell, the first image is probably a bug. The game only updates set bonuses when an item is equipped/unequipped, so there are three possibilities here:

1) A bug caused the game to skip the update code when that item was equipped
2) That character hasn't changed gear since before the change that prevented set bonus mixing
3) A hacker modified the gear directly

2 is pretty much impossible (pretty certain barbarian was released after that patch), but there are probably edge cases where the game can fail to update set bonuses. 3 is possible enough.

Looking at the code, though... there's an edge case which allows items through the quality-level check. Put simply, when the game loops through the code, it doesn't set the "isMythical" tag until it encounters a mythical or above item - it doesn't go back to check items it already looped through, so if it encounters a godly item in slot 1, and then mythical items in slots 2 through 4, it'll still allow a set bonus.

So what I just said in that last paragraph is probably the real cause of the bug; and yes, it's definitely a bug.

Code needs to go back to the first item if it finds a myth, or do a better myth check which also has flags for non-myth so it cancels if it finds a non-myth followed by a myth.


@Commish - Unreal engine always rounds down when converting floating points to integers (rounding to the nearest whole number).

[Chris the ranger]

My proof from the other thread

Mixing
Not mixing

!!

Interesting, so godly doesn't mix, but anything below it does?

[Dingle]

Interesting, so godly doesn't mix, but anything below it does?

That's not it, exactly - from my last post:

Looking at the code, though... there's an edge case which allows items through the quality-level check. Put simply, when the game loops through the code, it doesn't set the "isMythical" tag until it encounters a mythical or above item - it doesn't go back to check items it already looped through, so if it encounters a godly item in slot 1, and then mythical items in slots 2 through 4, it'll still allow a set bonus.

Put simply, it depends on which slots the items are in; I'm not sure the exact layout of the equip slots, but you can trick the set bonus into working with any combination of gear quality as long as the pieces are in the right slots. It's an issue with how it's coded, and definitely not intended.

[Rageamok]

My proof from the other thread

Mixing
Not mixing

!!

screenshots are from 19th April, the 2 armor pieces were tavern bought after doing a few runs to check, had full mythical gear equipped before swapping out for the piece in the screenshot in both cases, to see that one worked and one didn't ><

it's my opinion that they should all mix anyway, as having them not only hurts the person breaking into myth gear, cause as soon as you get a full myth set all your godly and lower stuff gets sold.. lol